Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LPMS with the mobile transcoding fix #3003

Merged
merged 3 commits into from
May 13, 2024

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Apr 12, 2024

No description provided.

@leszko leszko force-pushed the rafal/update-lpms-fix-mobile branch from cdf854c to f0d60b1 Compare May 13, 2024 16:24
@leszko leszko merged commit 5f8bc55 into master May 13, 2024
18 checks passed
@leszko leszko deleted the rafal/update-lpms-fix-mobile branch May 13, 2024 16:57
rickstaa added a commit that referenced this pull request Aug 7, 2024
* eth,eth/watcher: Create Chainlink price feed watcher (#2972)

* eth/watchers: Create PriceFeed watcher

Makefile: Use mockgen binary from tool dependencies

eth/contracts: Add chainlink interfaces source

Makefile: Generate Chainlink contracts ABI

tools: Add abigen tool to repo

eth/contracts: Generate chainlink bindings

Makefile: Fix abigen bindings generation

Revert everything abigen

Turns out there's already bindings exported from the Chainlink lib.

go.mod: Add chainlink library

eth/watchers: Add pricefeed watcher

eth/watchers: Clean-up event watching code

eth/watchers: Improve price tracking

Revert "go.mod: Add chainlink library"

This reverts commit ac415bd.

Revert "Revert everything abigen"

This reverts commit b7c40b1.

eth/contracts: Gen bindings for proxy iface

eth/watchers: Use local bindings for contracts

eth/watchers: Simplify event subs logic

eth/watchers: Simplify&optimize truncated ticker

eth/watchers: Update decimals on fetch

eth/watchers: Improve handling of decimals

eth/watchers: Fix price rat creation

eth/watchers: Make sure we use UTC on truncated timer

eth/contracts/chainlink: Generate only V3 contract bindings

eth/watchers: Watch PriceFeed only with polling

eth/watchers: Add a retry logic on price update

eth/watchers: Use clog instead of fmt.Printf

* eth: Create separate pricefeed client unit

This will make the code more testable.

* eth: Add tests for pricefeed client

* eth/watchers: Add tests to the truncated ticker

Gosh that was much harder than I thought

* eth/watchers: Add tests for pricefeedwatcher

* eth: Add comments to the new components

* go fmt

* eth: Address minor review comments

* eth,eth/watchers: Improve pricefeed watcher interface

* eth/watchers: Remove truncated ticker tests

* cmd/livepeer: Use price feed watcher for dynamic pricePerPixel (#2981)

* eth/watchers: Create PriceFeed watcher

Makefile: Use mockgen binary from tool dependencies

eth/contracts: Add chainlink interfaces source

Makefile: Generate Chainlink contracts ABI

tools: Add abigen tool to repo

eth/contracts: Generate chainlink bindings

Makefile: Fix abigen bindings generation

Revert everything abigen

Turns out there's already bindings exported from the Chainlink lib.

go.mod: Add chainlink library

eth/watchers: Add pricefeed watcher

eth/watchers: Clean-up event watching code

eth/watchers: Improve price tracking

Revert "go.mod: Add chainlink library"

This reverts commit ac415bd.

Revert "Revert everything abigen"

This reverts commit b7c40b1.

eth/contracts: Gen bindings for proxy iface

eth/watchers: Use local bindings for contracts

eth/watchers: Simplify event subs logic

eth/watchers: Simplify&optimize truncated ticker

eth/watchers: Update decimals on fetch

eth/watchers: Improve handling of decimals

eth/watchers: Fix price rat creation

eth/watchers: Make sure we use UTC on truncated timer

eth/contracts/chainlink: Generate only V3 contract bindings

eth/watchers: Watch PriceFeed only with polling

eth/watchers: Add a retry logic on price update

eth/watchers: Use clog instead of fmt.Printf

* eth: Create separate pricefeed client unit

This will make the code more testable.

* eth: Add tests for pricefeed client

* eth/watchers: Add tests to the truncated ticker

Gosh that was much harder than I thought

* eth/watchers: Add tests for pricefeedwatcher

* eth: Add comments to the new components

* go fmt

* cmd: make pricePerUnit flags strings

* cmd: Allow price per unit to be speficied with a currency

Currently ignoring the currency value.

* cmd: Add logic to start price update loop

* cmd: Add flag for specifying price feed address

* cmd: Add a lil test to priceDataToWei

* TODO: Reminder for something I noticed is missing

* cmd/starter: Support currencies for custom broadcaster prices

* eth: Address minor review comments

* eth,eth/watchers: Improve pricefeed watcher interface

* eth/watchers: Fix pricefeed watcher after merge

* cmd,core,server: Support dynamic updates to price in USD

* eth/watchers: Remove truncated ticker tests

* eth/watchers: Finalize pricefeedwatcher docs/tests

* cmd: Address review comment

* core: Create tests for autoconvertedprice

* cmd,core: Move wei default to AutoConvertedPrice

* Address review comments

* cmd: Fix the e2e flow for setting/updating configs

* CHANGELOG

* cmd: Make sure pricePerPixel can be specified with e notation

Parse it directlty as a big.Rat from a raw string, like I was
doing for pricePerUnit in some places.

* Fix tests

Turns out tests were not running on my branch due to base branch

* go fmt

* core: Fix typo in comment

* cmd,server: Use 3 decimal points when logging PPP

Found out that's officially supported precision on the
discovery logic, so let's reflect that here.

* Release 0.7.3 (#2988)

* release v0.7.3

* release v0.7.3

* Revert "Bump ffmpeg version and nv-codec-headers" (#2989)

* Revert "Bump ffmpeg version and nv-codec-headers (#2973)"

This reverts commit cad6713.

* Revert "Update CUDA build version from 11.7.1 to 12.0.0 (#2978)"

This reverts commit 6c09a9f.

* Reapply "Update CUDA build version from 11.7.1 to 12.0.0 (#2978)"

This reverts commit ebbf210.

* Force ffmpeg reinstall

* Revert "Force ffmpeg reinstall"

This reverts commit 5adb9a5.

---------

Co-authored-by: Victor Elias <victorgelias@gmail.com>

* Bump LPMS (#2992)

* release v0.7.4 (#2993)

* server: Skip redundant maxPrice check in ongoing session (#2994)

* server: Remove maxPrice check mid-session

* server: Fix tests

* server: Fix erroneous usage of assert.EqualErrorf

When I was writing the tests for validatePrice I found out
we were using that function wrong in a couple places and
never checking any error. We were sending err.Error() to check
the error from err.

* server: Fix error checks after fixing assertion

* CHANGELOG

* server: Allow Os price to increase up to 2x mid-session (#2995)

* server: Allow dynamic (and sometimes >max) prices for Os

* CHANGELOG

* server,discovery: Allow B to use any O in case none match maxPrice (#2999)

* discovery: Ignore maxPrice on db_discovery queries

Still kept the feature on the db as it had all the tests
already implemented and could still be useful in the future.
I can remove it if preferred though.

* server: Get prices as big rats for selection

While this may not seem useful now since we just convert
them to floats on the probability calculation, it will be
useful later when comparing prices to max price.

* server: Add maxPrice filter logic on selection algorithm

* CHANGELOG

* server: Break filter in 2 functions

* Fix transcoding price metrics (#3001)

* ci(ai): add AI issue templates

This commit introduces two new AI-specific issue templates, aiming to streamline
the routing of AI subnet-related issues and feature requests to the appropriate team.

* ci(ai): add AI pull request labeler

This commit adds a pull request labeler action that automatically
attaches the `ai` label when a pull request is created to the `ai-video`
branch.

* ci: change issue template order and add PR labeler config (#3006)

* ci: change issue template order

This commit ensures that the main branch issue templates are put above
the AI related issue templates.

* ci(ai): add PR labeler config file

This commmit adds a https://github.com/actions/labeler configuration
file so that all PRs on the `ai-video` branch will be correctly labeled
with the `ai` label.

* ci(ai): fix incorrect labels (#3012)

* ci(ai): fix incorrect labels

This commit fixed the labels that were specified in the Issue Templates
to the one found in the repository.

* ci: rename labeler and remove trailing whitespace

* ci(ai): fix pull request config warning (#3018) (#3019)

* ci(ai): fix pull request config warning (#3018)

This commit gets rid of the Pull request labeler configuration file
warning.

* ci(ai): auto assign AI issues

This commit auto assigns the AI issues to the right member of the AI
team.

* ci(ai): cleanup labeler actions

This commit cleans up the labeler actions and ensure they run on the
right triggers.

* Initialize round by any B/O who has the initializeRound flag set to true (#3029)

* Fix CI Darwin Build (#3049)

* Fix CI

* Fix CI

* chore: fix function names (#3040)

Signed-off-by: kevincatty <zhanshanmao@outlook.com>
Co-authored-by: Rafał Leszko <rafal@livepeer.org>

* Create option to filter Os by min livepeer version used (#3050)

* Update LPMS with the mobile transcoding fix (#3003)

* Release 0.7.5 (#3051)

* refactor: add -gateway and deprecate -broadcaster (#3053)

* refactor: add -gateway and deprecate -broadcaster

This commit adds the `gateway` flag and deprecates the `broadcaster` flag
per core team decision (details:
https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

---------

Co-authored-by: John | Elite Encoder <john@eliteencoder.net>

* refactor(census): rename Broadcaster metrics to Gateway (#3055)

* refactor(census): rename Broadcaster metrics to Gateway

This commit renames the metrics related to Broadcaster to Gateway, following
a team decision. More details can be found in the discussion
here:
[Team Discussion Link](.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

* refactor: add -pricePerGateway and deprecate -pricePerBroadcaster (#3056)

* refactor: add -pricePerGateway and deprecate -pricePerBroadcaster

This commit adds the `pricePerGateway` flag and deprecates the `pricePerBroadcaster` flag
per core team decision (details:
https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

* refactor: remove redundant deprecation comment

This commit removes the `PricePerBroadcaster` deprecation comment since
this is already clear from the glog warning below.

* fix: correct the `pricePerBroadcaster` flag check

This commit ensures that the deprecation condition for the `pricePerBroadcaster`
flag properly handles the default empty string value.

* fix: ensure 'pricePerGateway' is used

This commit ensures that the `pricePerGateway` is correctly used instead
of the `pricePerBroadcaster` when it is set.

* refactor: deprecate 'pricePerGateway' broadcasters property in favor of 'gateways'

This commit updates the configuration to replace the `broadcasters` property
specified under the `pricePerGateway` flag with `gateways`. Additionally, it
ensures that a warning is issued when the deprecated property is still used.

* test: fix TestParseGetBroadcasterPrices test

This commit ensures that the TestParseGetBroadcasterPrices function uses
the new getGatewayPrices function.

* test: rename TestParseGetBroadcasterPrices to reflect Gateway naming

This commit updates the `TestParseGetBroadcasterPrices` function to
`TestParseGetGatewayPrices` to align with the new node naming convention.

* ci: protect Docker 'stable' tag (#3062)

This commit introduces a safeguard to ensure that the Docker image
tagged
as 'stable' is only pushed when a new tag is created on the stable
branch.
This prevents unintended updates to the stable Docker image, ensuring
consistency and reliability for users relying on the stable tag.

* Return appropriate errors when auth fails, not just 5xx (#3065)

* Return appropriate errors when auth fails, not just 5xx

* Fix unit tests for new signature

* Fix remaining tests

* Fix another test

* Refactor Forbidden to error type

* Refactor Forbidden to error type

---------

Co-authored-by: Rafał Leszko <rafal@livepeer.org>

* ci: fix syntax error in Docker action tags (#3068)

* ci: fix syntax error in Docker action tags

This commit addresses a syntax error in the Docker image tag creation
step.

* ci(docker): ensure stable tag is created on master branch

This commit ensures that the stable tag is created on the master branch.

* chore: fix some comments (#3070)

Signed-off-by: linghuying <1599935829@qq.com>

* Add logging to selection_algorithm.go (#3076)

* Add logging to selection_algorithm.go

* Add even more logging

* Fix typo in logs (#3079)

* Add ctx to logging for selection algorithm (#3080)

* Add ctx to logging for selection algorithm

* Reorg imports

* Fix unit tests

* chore: make function comment match function name (#3081)

Signed-off-by: tongjicoder <tongjicoder@icloud.com>

* refactor: rename internal references from Broadcaster to Gateway (#3060)

* refactor: rename internal references from Broadcaster to Gateway

This commit updates internal references from 'Broadcaster' to 'Gateway'
in accordance with the core team’s decision. For more details, refer to
the discussion: [Discord
Link](https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

* Add logging to the session refresh (#3083)

* Add `/healthz` endpoint (#3095)

* Update LPMS to ffmpeg 7 (#3096)

* install_ffmpeg: point to LPMS

* Update to use ffmpeg7 LPMS

* release v0.7.6

* chore(ai): ensure ai-video-rebased ffmpeg file is used

Since the lpms `ai-video` and `ai-video-rebase-main` branches are not
yet merged into the main branch we need to ensure the right AI
install_ffmpeg.sh script is used.

* chore(ai): remove local go module dependency

This commit removes the local go module dependency to lpms that was
accidentally commited.

* test: fix broadcast test

This commit fixes the bugs that were introduced by the AI codebas einto
the broadcast test functions.

* feat(ai): add dynamic pricePerUnit feature to AI pricing

This commit ensures that Orchestrators can set their pricing in USD and
the price gets updated dynamically.

* cmd: Use `-gateway` consistently

Avoid references to deprecated CLI flags.

* feat(ai): add minLivepeerVersion constraint and IgnorePreReleaseVersions

- Adds minLivepeerVersion constraint from
  #3050 to the AI codebase.
- Introduces `IgnorePreReleaseVersions` flag to filter out pre-release versions.

This update is essential for distinguishing AI subnet versions, which use pre-release
suffixes, from standard transcoding releases. This new flag can be
removed when merging in the main branch.

* fix(ai): fix offchain 'PriceFeedWatcher is not initialized' error

This commit ensures that the `PriceFeedWatcher is not initialized` error
is not thrown when the software is run in `offchain` mode.

* test: add pre-release suffix min version tests

This commit adds some tests to check if pre-release versions are
correctly handled when filtering orchestrators based on minimum version.

* feat: simplify pre-release version filter logic

This commit removes the POC `ignorePreReleaseVersions` command line
argument for logic in the `LivepeerVersionCompatibleWith` which ensures
that pre-release versions are only checked when the gateway specifies as
pre-release suffix in the `orchMinLivepeerVersion` command line
argument.

* feat: allow Gateways to filter by pre-release

This commit gives Gateways the ability to filter by pre-release suffix.
When a pre-release suffix is specified in the `OrchMinLivepeerVersion`
command line argument the software now also checks the pre-release
version suffix on the orchestrator.

* refactor(ai): rename capability constraint variable

This commit renames the orchConstraints variable in the capabilities.go
file to better reflect that it are constraints per capabilities.

* chore(ai): remove lpms local dependency

This commit ensure that the right remote dependency is used for the lpms
package.

* chore(ai): update lpms dependency

This commit updates the lpms dependency to the lastest version of the
`ai-video-rebase-main`.

* feat: remove AI specific minVersion constraint logic

This commit removes the ai-specific logic that allows ai suffixes to
work during version constraint checking. This was done to add it back in
a seperate commit so that we can always revert.

* feat(ai): Add AI suffix handling for min version logic

This commit introduces logic to handle version constraints with AI-specific
suffixes (e.g., v0.7.6-ai.1). This ensures compatibility during version
constraint filtering. Note that this logic should be removed when merging
into the master branch.

* core: Make the AI config take a big rat

* fix: add AIModels currency config field and fix pixelsPerUnit handling

This commit adds a new `currency` field to the `AIModelConfig` to specify the
currency. Additionally, it improves the AI startup code in `starter.go` to
correctly handle parsing of this currency while ensuring compatibility with
'offchain' mode. Further improvements to the AI startup code are deferred to
avoid conflicts with existing pull requests.

* fix(ai): temporarily disable arm64 builds

This commit disables the linux/arm64 for now as we haven't yet added support it.
This prevent the Docker CI from failing.

---------

Signed-off-by: kevincatty <zhanshanmao@outlook.com>
Signed-off-by: linghuying <1599935829@qq.com>
Signed-off-by: tongjicoder <tongjicoder@icloud.com>
Co-authored-by: Victor Elias <victor@livepeer.org>
Co-authored-by: Rafał Leszko <rafal@livepeer.org>
Co-authored-by: Thom Shutt <thomshutt@users.noreply.github.com>
Co-authored-by: Victor Elias <victorgelias@gmail.com>
Co-authored-by: kevincatty <168698033+kevincatty@users.noreply.github.com>
Co-authored-by: John | Elite Encoder <john@eliteencoder.net>
Co-authored-by: linghuying <1599935829@qq.com>
Co-authored-by: tongjicoder <tongjicoder@icloud.com>
Co-authored-by: Josh Allmann <joshua.allmann@gmail.com>
rickstaa added a commit that referenced this pull request Aug 7, 2024
This commit aims to synchronize the ai-video branch with the master branch. It addresses an issue where PR #3103 was not correctly recognized by GitHub as being in sync with the master branch.

* eth,eth/watcher: Create Chainlink price feed watcher (#2972)

* eth/watchers: Create PriceFeed watcher

Makefile: Use mockgen binary from tool dependencies

eth/contracts: Add chainlink interfaces source

Makefile: Generate Chainlink contracts ABI

tools: Add abigen tool to repo

eth/contracts: Generate chainlink bindings

Makefile: Fix abigen bindings generation

Revert everything abigen

Turns out there's already bindings exported from the Chainlink lib.

go.mod: Add chainlink library

eth/watchers: Add pricefeed watcher

eth/watchers: Clean-up event watching code

eth/watchers: Improve price tracking

Revert "go.mod: Add chainlink library"

This reverts commit ac415bd.

Revert "Revert everything abigen"

This reverts commit b7c40b1.

eth/contracts: Gen bindings for proxy iface

eth/watchers: Use local bindings for contracts

eth/watchers: Simplify event subs logic

eth/watchers: Simplify&optimize truncated ticker

eth/watchers: Update decimals on fetch

eth/watchers: Improve handling of decimals

eth/watchers: Fix price rat creation

eth/watchers: Make sure we use UTC on truncated timer

eth/contracts/chainlink: Generate only V3 contract bindings

eth/watchers: Watch PriceFeed only with polling

eth/watchers: Add a retry logic on price update

eth/watchers: Use clog instead of fmt.Printf

* eth: Create separate pricefeed client unit

This will make the code more testable.

* eth: Add tests for pricefeed client

* eth/watchers: Add tests to the truncated ticker

Gosh that was much harder than I thought

* eth/watchers: Add tests for pricefeedwatcher

* eth: Add comments to the new components

* go fmt

* eth: Address minor review comments

* eth,eth/watchers: Improve pricefeed watcher interface

* eth/watchers: Remove truncated ticker tests

* cmd/livepeer: Use price feed watcher for dynamic pricePerPixel (#2981)

* eth/watchers: Create PriceFeed watcher

Makefile: Use mockgen binary from tool dependencies

eth/contracts: Add chainlink interfaces source

Makefile: Generate Chainlink contracts ABI

tools: Add abigen tool to repo

eth/contracts: Generate chainlink bindings

Makefile: Fix abigen bindings generation

Revert everything abigen

Turns out there's already bindings exported from the Chainlink lib.

go.mod: Add chainlink library

eth/watchers: Add pricefeed watcher

eth/watchers: Clean-up event watching code

eth/watchers: Improve price tracking

Revert "go.mod: Add chainlink library"

This reverts commit ac415bd.

Revert "Revert everything abigen"

This reverts commit b7c40b1.

eth/contracts: Gen bindings for proxy iface

eth/watchers: Use local bindings for contracts

eth/watchers: Simplify event subs logic

eth/watchers: Simplify&optimize truncated ticker

eth/watchers: Update decimals on fetch

eth/watchers: Improve handling of decimals

eth/watchers: Fix price rat creation

eth/watchers: Make sure we use UTC on truncated timer

eth/contracts/chainlink: Generate only V3 contract bindings

eth/watchers: Watch PriceFeed only with polling

eth/watchers: Add a retry logic on price update

eth/watchers: Use clog instead of fmt.Printf

* eth: Create separate pricefeed client unit

This will make the code more testable.

* eth: Add tests for pricefeed client

* eth/watchers: Add tests to the truncated ticker

Gosh that was much harder than I thought

* eth/watchers: Add tests for pricefeedwatcher

* eth: Add comments to the new components

* go fmt

* cmd: make pricePerUnit flags strings

* cmd: Allow price per unit to be speficied with a currency

Currently ignoring the currency value.

* cmd: Add logic to start price update loop

* cmd: Add flag for specifying price feed address

* cmd: Add a lil test to priceDataToWei

* TODO: Reminder for something I noticed is missing

* cmd/starter: Support currencies for custom broadcaster prices

* eth: Address minor review comments

* eth,eth/watchers: Improve pricefeed watcher interface

* eth/watchers: Fix pricefeed watcher after merge

* cmd,core,server: Support dynamic updates to price in USD

* eth/watchers: Remove truncated ticker tests

* eth/watchers: Finalize pricefeedwatcher docs/tests

* cmd: Address review comment

* core: Create tests for autoconvertedprice

* cmd,core: Move wei default to AutoConvertedPrice

* Address review comments

* cmd: Fix the e2e flow for setting/updating configs

* CHANGELOG

* cmd: Make sure pricePerPixel can be specified with e notation

Parse it directlty as a big.Rat from a raw string, like I was
doing for pricePerUnit in some places.

* Fix tests

Turns out tests were not running on my branch due to base branch

* go fmt

* core: Fix typo in comment

* cmd,server: Use 3 decimal points when logging PPP

Found out that's officially supported precision on the
discovery logic, so let's reflect that here.

* Release 0.7.3 (#2988)

* release v0.7.3

* release v0.7.3

* Revert "Bump ffmpeg version and nv-codec-headers" (#2989)

* Revert "Bump ffmpeg version and nv-codec-headers (#2973)"

This reverts commit cad6713.

* Revert "Update CUDA build version from 11.7.1 to 12.0.0 (#2978)"

This reverts commit 6c09a9f.

* Reapply "Update CUDA build version from 11.7.1 to 12.0.0 (#2978)"

This reverts commit ebbf210.

* Force ffmpeg reinstall

* Revert "Force ffmpeg reinstall"

This reverts commit 5adb9a5.

---------

Co-authored-by: Victor Elias <victorgelias@gmail.com>

* Bump LPMS (#2992)

* release v0.7.4 (#2993)

* server: Skip redundant maxPrice check in ongoing session (#2994)

* server: Remove maxPrice check mid-session

* server: Fix tests

* server: Fix erroneous usage of assert.EqualErrorf

When I was writing the tests for validatePrice I found out
we were using that function wrong in a couple places and
never checking any error. We were sending err.Error() to check
the error from err.

* server: Fix error checks after fixing assertion

* CHANGELOG

* server: Allow Os price to increase up to 2x mid-session (#2995)

* server: Allow dynamic (and sometimes >max) prices for Os

* CHANGELOG

* server,discovery: Allow B to use any O in case none match maxPrice (#2999)

* discovery: Ignore maxPrice on db_discovery queries

Still kept the feature on the db as it had all the tests
already implemented and could still be useful in the future.
I can remove it if preferred though.

* server: Get prices as big rats for selection

While this may not seem useful now since we just convert
them to floats on the probability calculation, it will be
useful later when comparing prices to max price.

* server: Add maxPrice filter logic on selection algorithm

* CHANGELOG

* server: Break filter in 2 functions

* Fix transcoding price metrics (#3001)

* ci(ai): add AI issue templates

This commit introduces two new AI-specific issue templates, aiming to streamline
the routing of AI subnet-related issues and feature requests to the appropriate team.

* ci(ai): add AI pull request labeler

This commit adds a pull request labeler action that automatically
attaches the `ai` label when a pull request is created to the `ai-video`
branch.

* ci: change issue template order and add PR labeler config (#3006)

* ci: change issue template order

This commit ensures that the main branch issue templates are put above
the AI related issue templates.

* ci(ai): add PR labeler config file

This commmit adds a https://github.com/actions/labeler configuration
file so that all PRs on the `ai-video` branch will be correctly labeled
with the `ai` label.

* ci(ai): fix incorrect labels (#3012)

* ci(ai): fix incorrect labels

This commit fixed the labels that were specified in the Issue Templates
to the one found in the repository.

* ci: rename labeler and remove trailing whitespace

* ci(ai): fix pull request config warning (#3018) (#3019)

* ci(ai): fix pull request config warning (#3018)

This commit gets rid of the Pull request labeler configuration file
warning.

* ci(ai): auto assign AI issues

This commit auto assigns the AI issues to the right member of the AI
team.

* ci(ai): cleanup labeler actions

This commit cleans up the labeler actions and ensure they run on the
right triggers.

* Initialize round by any B/O who has the initializeRound flag set to true (#3029)

* Fix CI Darwin Build (#3049)

* Fix CI

* Fix CI

* chore: fix function names (#3040)

Signed-off-by: kevincatty <zhanshanmao@outlook.com>
Co-authored-by: Rafał Leszko <rafal@livepeer.org>

* Create option to filter Os by min livepeer version used (#3050)

* Update LPMS with the mobile transcoding fix (#3003)

* Release 0.7.5 (#3051)

* refactor: add -gateway and deprecate -broadcaster (#3053)

* refactor: add -gateway and deprecate -broadcaster

This commit adds the `gateway` flag and deprecates the `broadcaster` flag
per core team decision (details:
https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

---------

Co-authored-by: John | Elite Encoder <john@eliteencoder.net>

* refactor(census): rename Broadcaster metrics to Gateway (#3055)

* refactor(census): rename Broadcaster metrics to Gateway

This commit renames the metrics related to Broadcaster to Gateway, following
a team decision. More details can be found in the discussion
here:
[Team Discussion Link](.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

* refactor: add -pricePerGateway and deprecate -pricePerBroadcaster (#3056)

* refactor: add -pricePerGateway and deprecate -pricePerBroadcaster

This commit adds the `pricePerGateway` flag and deprecates the `pricePerBroadcaster` flag
per core team decision (details:
https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

* refactor: remove redundant deprecation comment

This commit removes the `PricePerBroadcaster` deprecation comment since
this is already clear from the glog warning below.

* fix: correct the `pricePerBroadcaster` flag check

This commit ensures that the deprecation condition for the `pricePerBroadcaster`
flag properly handles the default empty string value.

* fix: ensure 'pricePerGateway' is used

This commit ensures that the `pricePerGateway` is correctly used instead
of the `pricePerBroadcaster` when it is set.

* refactor: deprecate 'pricePerGateway' broadcasters property in favor of 'gateways'

This commit updates the configuration to replace the `broadcasters` property
specified under the `pricePerGateway` flag with `gateways`. Additionally, it
ensures that a warning is issued when the deprecated property is still used.

* test: fix TestParseGetBroadcasterPrices test

This commit ensures that the TestParseGetBroadcasterPrices function uses
the new getGatewayPrices function.

* test: rename TestParseGetBroadcasterPrices to reflect Gateway naming

This commit updates the `TestParseGetBroadcasterPrices` function to
`TestParseGetGatewayPrices` to align with the new node naming convention.

* ci: protect Docker 'stable' tag (#3062)

This commit introduces a safeguard to ensure that the Docker image
tagged
as 'stable' is only pushed when a new tag is created on the stable
branch.
This prevents unintended updates to the stable Docker image, ensuring
consistency and reliability for users relying on the stable tag.

* Return appropriate errors when auth fails, not just 5xx (#3065)

* Return appropriate errors when auth fails, not just 5xx

* Fix unit tests for new signature

* Fix remaining tests

* Fix another test

* Refactor Forbidden to error type

* Refactor Forbidden to error type

---------

Co-authored-by: Rafał Leszko <rafal@livepeer.org>

* ci: fix syntax error in Docker action tags (#3068)

* ci: fix syntax error in Docker action tags

This commit addresses a syntax error in the Docker image tag creation
step.

* ci(docker): ensure stable tag is created on master branch

This commit ensures that the stable tag is created on the master branch.

* chore: fix some comments (#3070)

Signed-off-by: linghuying <1599935829@qq.com>

* Add logging to selection_algorithm.go (#3076)

* Add logging to selection_algorithm.go

* Add even more logging

* Fix typo in logs (#3079)

* Add ctx to logging for selection algorithm (#3080)

* Add ctx to logging for selection algorithm

* Reorg imports

* Fix unit tests

* chore: make function comment match function name (#3081)

Signed-off-by: tongjicoder <tongjicoder@icloud.com>

* refactor: rename internal references from Broadcaster to Gateway (#3060)

* refactor: rename internal references from Broadcaster to Gateway

This commit updates internal references from 'Broadcaster' to 'Gateway'
in accordance with the core team’s decision. For more details, refer to
the discussion: [Discord
Link](https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

* Add logging to the session refresh (#3083)

* Add `/healthz` endpoint (#3095)

* Update LPMS to ffmpeg 7 (#3096)

* install_ffmpeg: point to LPMS

* Update to use ffmpeg7 LPMS

* release v0.7.6

* cmd: Use `-gateway` consistently

Avoid references to deprecated CLI flags.

* core: Rename 'InArray' to 'HasCapability' (#3118)

---------

Signed-off-by: kevincatty <zhanshanmao@outlook.com>
Signed-off-by: linghuying <1599935829@qq.com>
Signed-off-by: tongjicoder <tongjicoder@icloud.com>
Co-authored-by: Victor Elias <victor@livepeer.org>
Co-authored-by: Rafał Leszko <rafal@livepeer.org>
Co-authored-by: Thom Shutt <thomshutt@users.noreply.github.com>
Co-authored-by: Victor Elias <victorgelias@gmail.com>
Co-authored-by: kevincatty <168698033+kevincatty@users.noreply.github.com>
Co-authored-by: John | Elite Encoder <john@eliteencoder.net>
Co-authored-by: linghuying <1599935829@qq.com>
Co-authored-by: tongjicoder <tongjicoder@icloud.com>
Co-authored-by: Josh Allmann <joshua.allmann@gmail.com>
rickstaa added a commit that referenced this pull request Aug 7, 2024
* eth,eth/watcher: Create Chainlink price feed watcher (#2972)

* eth/watchers: Create PriceFeed watcher

Makefile: Use mockgen binary from tool dependencies

eth/contracts: Add chainlink interfaces source

Makefile: Generate Chainlink contracts ABI

tools: Add abigen tool to repo

eth/contracts: Generate chainlink bindings

Makefile: Fix abigen bindings generation

Revert everything abigen

Turns out there's already bindings exported from the Chainlink lib.

go.mod: Add chainlink library

eth/watchers: Add pricefeed watcher

eth/watchers: Clean-up event watching code

eth/watchers: Improve price tracking

Revert "go.mod: Add chainlink library"

This reverts commit ac415bd.

Revert "Revert everything abigen"

This reverts commit b7c40b1.

eth/contracts: Gen bindings for proxy iface

eth/watchers: Use local bindings for contracts

eth/watchers: Simplify event subs logic

eth/watchers: Simplify&optimize truncated ticker

eth/watchers: Update decimals on fetch

eth/watchers: Improve handling of decimals

eth/watchers: Fix price rat creation

eth/watchers: Make sure we use UTC on truncated timer

eth/contracts/chainlink: Generate only V3 contract bindings

eth/watchers: Watch PriceFeed only with polling

eth/watchers: Add a retry logic on price update

eth/watchers: Use clog instead of fmt.Printf

* eth: Create separate pricefeed client unit

This will make the code more testable.

* eth: Add tests for pricefeed client

* eth/watchers: Add tests to the truncated ticker

Gosh that was much harder than I thought

* eth/watchers: Add tests for pricefeedwatcher

* eth: Add comments to the new components

* go fmt

* eth: Address minor review comments

* eth,eth/watchers: Improve pricefeed watcher interface

* eth/watchers: Remove truncated ticker tests

* cmd/livepeer: Use price feed watcher for dynamic pricePerPixel (#2981)

* eth/watchers: Create PriceFeed watcher

Makefile: Use mockgen binary from tool dependencies

eth/contracts: Add chainlink interfaces source

Makefile: Generate Chainlink contracts ABI

tools: Add abigen tool to repo

eth/contracts: Generate chainlink bindings

Makefile: Fix abigen bindings generation

Revert everything abigen

Turns out there's already bindings exported from the Chainlink lib.

go.mod: Add chainlink library

eth/watchers: Add pricefeed watcher

eth/watchers: Clean-up event watching code

eth/watchers: Improve price tracking

Revert "go.mod: Add chainlink library"

This reverts commit ac415bd.

Revert "Revert everything abigen"

This reverts commit b7c40b1.

eth/contracts: Gen bindings for proxy iface

eth/watchers: Use local bindings for contracts

eth/watchers: Simplify event subs logic

eth/watchers: Simplify&optimize truncated ticker

eth/watchers: Update decimals on fetch

eth/watchers: Improve handling of decimals

eth/watchers: Fix price rat creation

eth/watchers: Make sure we use UTC on truncated timer

eth/contracts/chainlink: Generate only V3 contract bindings

eth/watchers: Watch PriceFeed only with polling

eth/watchers: Add a retry logic on price update

eth/watchers: Use clog instead of fmt.Printf

* eth: Create separate pricefeed client unit

This will make the code more testable.

* eth: Add tests for pricefeed client

* eth/watchers: Add tests to the truncated ticker

Gosh that was much harder than I thought

* eth/watchers: Add tests for pricefeedwatcher

* eth: Add comments to the new components

* go fmt

* cmd: make pricePerUnit flags strings

* cmd: Allow price per unit to be speficied with a currency

Currently ignoring the currency value.

* cmd: Add logic to start price update loop

* cmd: Add flag for specifying price feed address

* cmd: Add a lil test to priceDataToWei

* TODO: Reminder for something I noticed is missing

* cmd/starter: Support currencies for custom broadcaster prices

* eth: Address minor review comments

* eth,eth/watchers: Improve pricefeed watcher interface

* eth/watchers: Fix pricefeed watcher after merge

* cmd,core,server: Support dynamic updates to price in USD

* eth/watchers: Remove truncated ticker tests

* eth/watchers: Finalize pricefeedwatcher docs/tests

* cmd: Address review comment

* core: Create tests for autoconvertedprice

* cmd,core: Move wei default to AutoConvertedPrice

* Address review comments

* cmd: Fix the e2e flow for setting/updating configs

* CHANGELOG

* cmd: Make sure pricePerPixel can be specified with e notation

Parse it directlty as a big.Rat from a raw string, like I was
doing for pricePerUnit in some places.

* Fix tests

Turns out tests were not running on my branch due to base branch

* go fmt

* core: Fix typo in comment

* cmd,server: Use 3 decimal points when logging PPP

Found out that's officially supported precision on the
discovery logic, so let's reflect that here.

* Release 0.7.3 (#2988)

* release v0.7.3

* release v0.7.3

* Revert "Bump ffmpeg version and nv-codec-headers" (#2989)

* Revert "Bump ffmpeg version and nv-codec-headers (#2973)"

This reverts commit cad6713.

* Revert "Update CUDA build version from 11.7.1 to 12.0.0 (#2978)"

This reverts commit 6c09a9f.

* Reapply "Update CUDA build version from 11.7.1 to 12.0.0 (#2978)"

This reverts commit ebbf210.

* Force ffmpeg reinstall

* Revert "Force ffmpeg reinstall"

This reverts commit 5adb9a5.

---------

Co-authored-by: Victor Elias <victorgelias@gmail.com>

* Bump LPMS (#2992)

* release v0.7.4 (#2993)

* server: Skip redundant maxPrice check in ongoing session (#2994)

* server: Remove maxPrice check mid-session

* server: Fix tests

* server: Fix erroneous usage of assert.EqualErrorf

When I was writing the tests for validatePrice I found out
we were using that function wrong in a couple places and
never checking any error. We were sending err.Error() to check
the error from err.

* server: Fix error checks after fixing assertion

* CHANGELOG

* server: Allow Os price to increase up to 2x mid-session (#2995)

* server: Allow dynamic (and sometimes >max) prices for Os

* CHANGELOG

* server,discovery: Allow B to use any O in case none match maxPrice (#2999)

* discovery: Ignore maxPrice on db_discovery queries

Still kept the feature on the db as it had all the tests
already implemented and could still be useful in the future.
I can remove it if preferred though.

* server: Get prices as big rats for selection

While this may not seem useful now since we just convert
them to floats on the probability calculation, it will be
useful later when comparing prices to max price.

* server: Add maxPrice filter logic on selection algorithm

* CHANGELOG

* server: Break filter in 2 functions

* Fix transcoding price metrics (#3001)

* ci(ai): add AI issue templates

This commit introduces two new AI-specific issue templates, aiming to streamline
the routing of AI subnet-related issues and feature requests to the appropriate team.

* ci(ai): add AI pull request labeler

This commit adds a pull request labeler action that automatically
attaches the `ai` label when a pull request is created to the `ai-video`
branch.

* ci: change issue template order and add PR labeler config (#3006)

* ci: change issue template order

This commit ensures that the main branch issue templates are put above
the AI related issue templates.

* ci(ai): add PR labeler config file

This commmit adds a https://github.com/actions/labeler configuration
file so that all PRs on the `ai-video` branch will be correctly labeled
with the `ai` label.

* ci(ai): fix incorrect labels (#3012)

* ci(ai): fix incorrect labels

This commit fixed the labels that were specified in the Issue Templates
to the one found in the repository.

* ci: rename labeler and remove trailing whitespace

* ci(ai): fix pull request config warning (#3018) (#3019)

* ci(ai): fix pull request config warning (#3018)

This commit gets rid of the Pull request labeler configuration file
warning.

* ci(ai): auto assign AI issues

This commit auto assigns the AI issues to the right member of the AI
team.

* ci(ai): cleanup labeler actions

This commit cleans up the labeler actions and ensure they run on the
right triggers.

* Initialize round by any B/O who has the initializeRound flag set to true (#3029)

* Fix CI Darwin Build (#3049)

* Fix CI

* Fix CI

* chore: fix function names (#3040)

Signed-off-by: kevincatty <zhanshanmao@outlook.com>
Co-authored-by: Rafał Leszko <rafal@livepeer.org>

* Create option to filter Os by min livepeer version used (#3050)

* Update LPMS with the mobile transcoding fix (#3003)

* Release 0.7.5 (#3051)

* refactor: add -gateway and deprecate -broadcaster (#3053)

* refactor: add -gateway and deprecate -broadcaster

This commit adds the `gateway` flag and deprecates the `broadcaster` flag
per core team decision (details:
https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

---------

Co-authored-by: John | Elite Encoder <john@eliteencoder.net>

* refactor(census): rename Broadcaster metrics to Gateway (#3055)

* refactor(census): rename Broadcaster metrics to Gateway

This commit renames the metrics related to Broadcaster to Gateway, following
a team decision. More details can be found in the discussion
here:
[Team Discussion Link](.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

* refactor: add -pricePerGateway and deprecate -pricePerBroadcaster (#3056)

* refactor: add -pricePerGateway and deprecate -pricePerBroadcaster

This commit adds the `pricePerGateway` flag and deprecates the `pricePerBroadcaster` flag
per core team decision (details:
https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

* refactor: remove redundant deprecation comment

This commit removes the `PricePerBroadcaster` deprecation comment since
this is already clear from the glog warning below.

* fix: correct the `pricePerBroadcaster` flag check

This commit ensures that the deprecation condition for the `pricePerBroadcaster`
flag properly handles the default empty string value.

* fix: ensure 'pricePerGateway' is used

This commit ensures that the `pricePerGateway` is correctly used instead
of the `pricePerBroadcaster` when it is set.

* refactor: deprecate 'pricePerGateway' broadcasters property in favor of 'gateways'

This commit updates the configuration to replace the `broadcasters` property
specified under the `pricePerGateway` flag with `gateways`. Additionally, it
ensures that a warning is issued when the deprecated property is still used.

* test: fix TestParseGetBroadcasterPrices test

This commit ensures that the TestParseGetBroadcasterPrices function uses
the new getGatewayPrices function.

* test: rename TestParseGetBroadcasterPrices to reflect Gateway naming

This commit updates the `TestParseGetBroadcasterPrices` function to
`TestParseGetGatewayPrices` to align with the new node naming convention.

* ci: protect Docker 'stable' tag (#3062)

This commit introduces a safeguard to ensure that the Docker image
tagged
as 'stable' is only pushed when a new tag is created on the stable
branch.
This prevents unintended updates to the stable Docker image, ensuring
consistency and reliability for users relying on the stable tag.

* Return appropriate errors when auth fails, not just 5xx (#3065)

* Return appropriate errors when auth fails, not just 5xx

* Fix unit tests for new signature

* Fix remaining tests

* Fix another test

* Refactor Forbidden to error type

* Refactor Forbidden to error type

---------

Co-authored-by: Rafał Leszko <rafal@livepeer.org>

* ci: fix syntax error in Docker action tags (#3068)

* ci: fix syntax error in Docker action tags

This commit addresses a syntax error in the Docker image tag creation
step.

* ci(docker): ensure stable tag is created on master branch

This commit ensures that the stable tag is created on the master branch.

* chore: fix some comments (#3070)

Signed-off-by: linghuying <1599935829@qq.com>

* Add logging to selection_algorithm.go (#3076)

* Add logging to selection_algorithm.go

* Add even more logging

* Fix typo in logs (#3079)

* Add ctx to logging for selection algorithm (#3080)

* Add ctx to logging for selection algorithm

* Reorg imports

* Fix unit tests

* chore: make function comment match function name (#3081)

Signed-off-by: tongjicoder <tongjicoder@icloud.com>

* refactor: rename internal references from Broadcaster to Gateway (#3060)

* refactor: rename internal references from Broadcaster to Gateway

This commit updates internal references from 'Broadcaster' to 'Gateway'
in accordance with the core team’s decision. For more details, refer to
the discussion: [Discord
Link](https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).

* chore: update pending changelog

* Add logging to the session refresh (#3083)

* Add `/healthz` endpoint (#3095)

* Update LPMS to ffmpeg 7 (#3096)

* install_ffmpeg: point to LPMS

* Update to use ffmpeg7 LPMS

* release v0.7.6

* chore(ai): ensure ai-video-rebased ffmpeg file is used

Since the lpms `ai-video` and `ai-video-rebase-main` branches are not
yet merged into the main branch we need to ensure the right AI
install_ffmpeg.sh script is used.

* chore(ai): remove local go module dependency

This commit removes the local go module dependency to lpms that was
accidentally commited.

* test: fix broadcast test

This commit fixes the bugs that were introduced by the AI codebas einto
the broadcast test functions.

* feat(ai): add dynamic pricePerUnit feature to AI pricing

This commit ensures that Orchestrators can set their pricing in USD and
the price gets updated dynamically.

* cmd: Use `-gateway` consistently

Avoid references to deprecated CLI flags.

* feat(ai): add minLivepeerVersion constraint and IgnorePreReleaseVersions

- Adds minLivepeerVersion constraint from
  #3050 to the AI codebase.
- Introduces `IgnorePreReleaseVersions` flag to filter out pre-release versions.

This update is essential for distinguishing AI subnet versions, which use pre-release
suffixes, from standard transcoding releases. This new flag can be
removed when merging in the main branch.

* fix(ai): fix offchain 'PriceFeedWatcher is not initialized' error

This commit ensures that the `PriceFeedWatcher is not initialized` error
is not thrown when the software is run in `offchain` mode.

* test: add pre-release suffix min version tests

This commit adds some tests to check if pre-release versions are
correctly handled when filtering orchestrators based on minimum version.

* feat: simplify pre-release version filter logic

This commit removes the POC `ignorePreReleaseVersions` command line
argument for logic in the `LivepeerVersionCompatibleWith` which ensures
that pre-release versions are only checked when the gateway specifies as
pre-release suffix in the `orchMinLivepeerVersion` command line
argument.

* feat: allow Gateways to filter by pre-release

This commit gives Gateways the ability to filter by pre-release suffix.
When a pre-release suffix is specified in the `OrchMinLivepeerVersion`
command line argument the software now also checks the pre-release
version suffix on the orchestrator.

* refactor(ai): rename capability constraint variable

This commit renames the orchConstraints variable in the capabilities.go
file to better reflect that it are constraints per capabilities.

* chore(ai): remove lpms local dependency

This commit ensure that the right remote dependency is used for the lpms
package.

* chore(ai): update lpms dependency

This commit updates the lpms dependency to the lastest version of the
`ai-video-rebase-main`.

* feat: remove AI specific minVersion constraint logic

This commit removes the ai-specific logic that allows ai suffixes to
work during version constraint checking. This was done to add it back in
a seperate commit so that we can always revert.

* feat(ai): Add AI suffix handling for min version logic

This commit introduces logic to handle version constraints with AI-specific
suffixes (e.g., v0.7.6-ai.1). This ensures compatibility during version
constraint filtering. Note that this logic should be removed when merging
into the master branch.

* core: Make the AI config take a big rat

* fix: add AIModels currency config field and fix pixelsPerUnit handling

This commit adds a new `currency` field to the `AIModelConfig` to specify the
currency. Additionally, it improves the AI startup code in `starter.go` to
correctly handle parsing of this currency while ensuring compatibility with
'offchain' mode. Further improvements to the AI startup code are deferred to
avoid conflicts with existing pull requests.

* fix(ai): temporarily disable arm64 builds

This commit disables the linux/arm64 for now as we haven't yet added support it.
This prevent the Docker CI from failing.

---------

Signed-off-by: kevincatty <zhanshanmao@outlook.com>
Signed-off-by: linghuying <1599935829@qq.com>
Signed-off-by: tongjicoder <tongjicoder@icloud.com>
Co-authored-by: Victor Elias <victor@livepeer.org>
Co-authored-by: Rafał Leszko <rafal@livepeer.org>
Co-authored-by: Thom Shutt <thomshutt@users.noreply.github.com>
Co-authored-by: Victor Elias <victorgelias@gmail.com>
Co-authored-by: kevincatty <168698033+kevincatty@users.noreply.github.com>
Co-authored-by: John | Elite Encoder <john@eliteencoder.net>
Co-authored-by: linghuying <1599935829@qq.com>
Co-authored-by: tongjicoder <tongjicoder@icloud.com>
Co-authored-by: Josh Allmann <joshua.allmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants